Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Rename MQTT port variable for docker environment #1170

Merged
merged 1 commit into from
May 12, 2020
Merged

NOISSUE - Rename MQTT port variable for docker environment #1170

merged 1 commit into from
May 12, 2020

Conversation

blokovi
Copy link
Contributor

@blokovi blokovi commented May 12, 2020 •
edited
Loading

Signed-off-by: Ivan Milošević iva@blokovi.com

Align name of variable with mqtt/main.go

@blokovi
Rename environment variable MF_MQTT_ADAPTER_PORT to MF_MQTT_ADAPTER_M…
d98bdbc 
…QTT_PORT in docker environment

Signed-off-by: Ivan Milošević <iva@blokovi.com>
@blokovi blokovi requested a review from a team as a code owner May 12, 2020 12:16
nmarcetic
nmarcetic reviewed May 12, 2020
View reviewed changes
Copy link
Collaborator

@nmarcetic nmarcetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to rename vars in the helm chart also.

@blokovi
Copy link
Contributor Author

blokovi commented May 12, 2020 •
edited
Loading

Please don't forget to rename vars in the helm chart also.

In fact, there was already good var name, in docker is wrong

manuio
manuio approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drasko
drasko approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 5089fcc into absmach:master May 12, 2020
manuio pushed a commit that referenced this pull request Oct 12, 2020
@blokovi
Rename environment variable MF_MQTT_ADAPTER_PORT to MF_MQTT_ADAPTER_M…
822973c 
…QTT_PORT in docker environment (#1170)

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuio manuio manuio approved these changes

@nmarcetic nmarcetic nmarcetic approved these changes

@drasko drasko drasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blokovi @drasko @nmarcetic @manuio